He did a lot of dross, and he appears to have been..well, mad.
But he was brilliant, for all his erraticism. The Goons were his crowning achievement, as were the first five volumes of his war memoirs.
This film, the Great McGonagall, which he wrote and stared in, bombed badly at the time. But I have a certain fondness for its sheer weirdness.